fix: link app dependencies to their community app store - #2195
Open
ryanwaits wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a community app store's app page, the Requires section links every dependency to
/app-store/<id>. When the dependency lives in that community store, the route has no app and lands on the error boundary. The Install button in the dependency selection dialog has the same hardcoded path. There's an existing TODO acknowledging it, but it points atgetAppStoreAppFromInstalledApp, which was removed in 4cf8ec3.Fixes #2194
Fix
Add a
getAppStoreLinkhelper toapp-store/utils.tsthat routes community store apps to/community-app-store/<storeId>/<appId>and everything else to the official route, using theappStoreIdthe registry already hydrates onto every app. It's the same branch the desktop context menu's "go to store page" already does inapp-icon.tsx. Both dependency surfaces now use it. The dialog falls back to the official route when the app isn't present in any store anymore (e.g. a removed community app store), which preserves current behavior. Official-store dependencies produce identical paths, so nothing changes there.Testing
Manually in umbrel-dev with a local community app store containing two apps where one depends on the other:
/community-app-store/example-store/example-store-serviceand open a working app page. Before the fix they pointed to/app-store/example-store-serviceand landed on "Something went wrong"./app-store/bitcoinand work. Selecting an alternative in the dialog (Bitcoin Knots) links to/app-store/bitcoin-knotscorrectly.Caveat
Tested in the umbrel-dev VM (Docker/macOS), not on real umbrelOS hardware.